From c78b98d36b79aa3390e3f6ac9f306b6f8ac5196b Mon Sep 17 00:00:00 2001 From: Bill Somerville Date: Wed, 27 May 2020 11:19:30 +0100 Subject: [PATCH] Revert "Add debug to serial.c" This reverts commit be439ea394004a7a96b04bd3c22b6ccfc520a57a. Remove debugging code that breaks the intended functionality. How did this change pass even the most basic of tests? --- src/rig.c | 1 - src/serial.c | 8 +------- 2 files changed, 1 insertion(+), 8 deletions(-) diff --git a/src/rig.c b/src/rig.c index 304b39d19..51835e1f7 100644 --- a/src/rig.c +++ b/src/rig.c @@ -2117,7 +2117,6 @@ int HAMLIB_API rig_set_ptt(RIG *rig, vfo_t vfo, ptt_t ptt) && ptt == RIG_PTT_OFF) { - rig_debug(RIG_DEBUG_ERR, "%s: PTT RTS debug#3\n", __func__); /* free the port */ ser_close(&rs->pttport); } diff --git a/src/serial.c b/src/serial.c index 63625a485..358320448 100644 --- a/src/serial.c +++ b/src/serial.c @@ -808,13 +808,10 @@ int HAMLIB_API ser_set_rts(hamlib_port_t *p, int state) } #if defined(TIOCMBIS) && defined(TIOCMBIC) - rc = IOCTL(p->fd, TIOCMGET, &y); - rig_debug(RIG_DEBUG_TRACE,"%s: IOCTL#1 got y=%d\n", __func__, y); rc = IOCTL(p->fd, state ? TIOCMBIS : TIOCMBIC, &y); - rig_debug(RIG_DEBUG_TRACE,"%s: IOCTL#1 after set y=%d\n", __func__, y); #else rc = IOCTL(p->fd, TIOCMGET, &y); - rig_debug(RIG_DEBUG_TRACE,"%s: IOCTL#2 got y=%d\n", __func__, y); + if (rc >= 0) { if (state) @@ -826,10 +823,7 @@ int HAMLIB_API ser_set_rts(hamlib_port_t *p, int state) y &= ~TIOCM_RTS; } - rig_debug(RIG_DEBUG_TRACE,"%s: IOCTL#2 set y=%d\n", __func__, y); rc = IOCTL(p->fd, TIOCMSET, &y); - rc = IOCTL(p->fd, TIOCMGET, &y); - rig_debug(RIG_DEBUG_TRACE,"%s: IOCTL#2 after set y=%d\n", __func__, y); } #endif