From 045c0cff2124de134cc20c0fdb3525cb7e46af62 Mon Sep 17 00:00:00 2001 From: Michael Black W9MDB Date: Fri, 3 Jul 2020 16:59:52 -0500 Subject: [PATCH] Fix cppcheck warnings --- dummy/netrigctl.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/dummy/netrigctl.c b/dummy/netrigctl.c index d8b5a116d..89a5dd327 100644 --- a/dummy/netrigctl.c +++ b/dummy/netrigctl.c @@ -718,7 +718,7 @@ static int netrigctl_get_mode(RIG *rig, vfo_t vfo, rmode_t *mode, return (ret < 0) ? ret : -RIG_EPROTO; } - if (ret > 0 && buf[ret - 1] == '\n') { buf[ret - 1] = '\0'; } /* chomp */ + if (buf[ret - 1] == '\n') { buf[ret - 1] = '\0'; } /* chomp */ *mode = rig_parse_mode(buf); @@ -790,7 +790,7 @@ static int netrigctl_get_vfo(RIG *rig, vfo_t *vfo) return (ret < 0) ? ret : -RIG_EPROTO; } - if (ret > 0 && buf[ret - 1] == '\n') { buf[ret - 1] = '\0'; } /* chomp */ + if (buf[ret - 1] == '\n') { buf[ret - 1] = '\0'; } /* chomp */ *vfo = rig_parse_vfo(buf); @@ -935,7 +935,7 @@ static int netrigctl_get_rptr_shift(RIG *rig, vfo_t vfo, return (ret < 0) ? ret : -RIG_EPROTO; } - if (ret > 0 && buf[ret - 1] == '\n') { buf[ret - 1] = '\0'; } /* chomp */ + if (buf[ret - 1] == '\n') { buf[ret - 1] = '\0'; } /* chomp */ *rptr_shift = rig_parse_rptr_shift(buf); @@ -1329,7 +1329,7 @@ static int netrigctl_get_split_mode(RIG *rig, vfo_t vfo, rmode_t *tx_mode, return (ret < 0) ? ret : -RIG_EPROTO; } - if (ret > 0 && buf[ret - 1] == '\n') { buf[ret - 1] = '\0'; } /* chomp */ + if (buf[ret - 1] == '\n') { buf[ret - 1] = '\0'; } /* chomp */ *tx_mode = rig_parse_mode(buf); @@ -1407,7 +1407,7 @@ static int netrigctl_get_split_vfo(RIG *rig, vfo_t vfo, split_t *split, } - if (ret > 0 && buf[ret - 1] == '\n') { buf[ret - 1] = '\0'; } /* chomp */ + if (buf[ret - 1] == '\n') { buf[ret - 1] = '\0'; } /* chomp */ *tx_vfo = rig_parse_vfo(buf);