From 2824f31ac6a4f0271ad362ae349251b406551e3f Mon Sep 17 00:00:00 2001
From: int2001 <joerg@dj7nt.de>
Date: Thu, 3 Aug 2023 08:55:16 +0000
Subject: [PATCH] Disabled "use for print" if no paper given, catching error if
 those label was active

---
 application/controllers/Labels.php | 44 ++++++++++++++++++------------
 application/views/labels/index.php |  4 +++
 2 files changed, 31 insertions(+), 17 deletions(-)

diff --git a/application/controllers/Labels.php b/application/controllers/Labels.php
index b1c05642..d393be90 100644
--- a/application/controllers/Labels.php
+++ b/application/controllers/Labels.php
@@ -162,22 +162,32 @@ class Labels extends CI_Controller {
 		try {
 			if ($label) {
 				$ptype=$this->labels_model->getPaperType($label->paper_type_id);	// fetch papersize out of paper-table
-				// var_dump($ptype);
-				$pdf = new PDF_Label(array(
-					'paper-size'	=> 'custom', 				// $label->paper_type,	// The only Type left is "custom" because A4 and so on are also defined at paper_types
-					'metric'		=> $label->metric,
-					'marginLeft'	=> $label->marginleft,
-					'marginTop'		=> $label->margintop,
-					'NX'			=> $label->nx,
-					'NY'			=> $label->ny,
-					'SpaceX'		=> $label->spacex,
-					'SpaceY'		=> $label->spacey,
-					'width'			=> $label->width,
-					'height'		=> $label->height,
-					'font-size'		=> $label->font_size,
-					'pgX'		=> $ptype->width,
-					'pgY'		=> $ptype->height
-				));
+				if (($ptype->paper_id ?? '') != '') {
+					$pdf = new PDF_Label(array(
+						'paper-size'	=> 'custom', 				// $label->paper_type,	// The only Type left is "custom" because A4 and so on are also defined at paper_types
+						'metric'		=> $label->metric,
+						'marginLeft'	=> $label->marginleft,
+						'marginTop'		=> $label->margintop,
+						'NX'			=> $label->nx,
+						'NY'			=> $label->ny,
+						'SpaceX'		=> $label->spacex,
+						'SpaceY'		=> $label->spacey,
+						'width'			=> $label->width,
+						'height'		=> $label->height,
+						'font-size'		=> $label->font_size,
+						'pgX'		=> $ptype->width,
+						'pgY'		=> $ptype->height
+					));
+				} else {
+					if ($jscall) {
+						header('Content-Type: application/json');
+						echo json_encode(array('message' => 'You need to assign a paperType to the label before printing'));
+						return;
+					} else {
+						$this->session->set_flashdata('error', 'You need to assign a paperType to the label before printing');
+						redirect('labels');
+					}
+				}
 			} else {
 				if ($jscall) {
 					header('Content-Type: application/json');
@@ -204,7 +214,7 @@ class Labels extends CI_Controller {
 
 		if ($label->font == 'DejaVuSans') {	// leave this here, for future Use
 			$pdf->AddFont($label->font,'','DejaVuSansMono.ttf',true);
-			$pdf->SetFont($label->font);
+			$pdf->SetFont($label->font,'');
 		} else {
 			$pdf->AddFont($label->font);
 			$pdf->SetFont($label->font);
diff --git a/application/views/labels/index.php b/application/views/labels/index.php
index b6f15b18..6f4ad7f1 100644
--- a/application/views/labels/index.php
+++ b/application/views/labels/index.php
@@ -95,7 +95,11 @@
 			<td><?php echo $label->font_size; ?></td>
 			<td><?php echo $label->qsos; ?></td>
 			<td><?php echo $label->last_modified; ?></td>
+			<?php if (($label->paper_name ?? '') == '') { ?>
+			<td></td>
+			<?php } else { ?>
 			<td><input type="checkbox" <?php if ($label->useforprint == 1) {echo 'checked';}?>></td>
+			<?php } ?>
 			<td><a href="<?php echo site_url('labels/edit/' . $label->id); ?>" class="btn btn-outline-primary btn-sm"><i class="fas fa-edit"></i></a></td>
 			<td><a href="<?php echo site_url('labels/delete/' . $label->id); ?>" class="btn btn-outline-danger btn-sm"><i class="fas fa-trash-alt"></i></a></td>
 			</tr>