From ed558ba5cacbe0582253a3b4f8b646bf6ec2f5c1 Mon Sep 17 00:00:00 2001 From: Alex Gleason Date: Tue, 18 Oct 2022 19:23:01 -0500 Subject: [PATCH] MediaModal: fix clicking Audio causes modal to close --- app/soapbox/features/ui/components/media-modal.tsx | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/app/soapbox/features/ui/components/media-modal.tsx b/app/soapbox/features/ui/components/media-modal.tsx index 0ceea724e..17bddabeb 100644 --- a/app/soapbox/features/ui/components/media-modal.tsx +++ b/app/soapbox/features/ui/components/media-modal.tsx @@ -101,12 +101,12 @@ const MediaModal: React.FC = (props) => { } }; - const handleCloserClick: React.MouseEventHandler = ({ currentTarget }) => { + const handleCloserClick: React.MouseEventHandler = ({ target }) => { const whitelist = ['zoomable-image']; const activeSlide = document.querySelector('.media-modal .react-swipeable-view-container > div[aria-hidden="false"]'); - const isClickOutside = currentTarget === activeSlide || !activeSlide?.contains(currentTarget); - const isWhitelisted = whitelist.some(w => currentTarget.classList.contains(w)); + const isClickOutside = target === activeSlide || !activeSlide?.contains(target as Element); + const isWhitelisted = whitelist.some(w => (target as Element).classList.contains(w)); if (isClickOutside || isWhitelisted) { onClose();