From df8ac668b800ecf64ab2c240678eb87b225cb513 Mon Sep 17 00:00:00 2001 From: Friendika Date: Wed, 8 Jun 2011 21:06:02 -0700 Subject: [PATCH 1/5] more calendar work, undo strict_privacy flag to use different approach --- boot.php | 18 +---- database.sql | 1 + images/calendar.png | Bin 0 -> 853 bytes include/event.php | 106 +++++++++++++++++++++++++----- include/notifier.php | 7 +- mod/dfrn_request.php | 8 +-- mod/follow.php | 3 - mod/salmon.php | 5 -- update.php | 7 +- view/theme/duepuntozero/style.css | 15 +++++ 10 files changed, 119 insertions(+), 51 deletions(-) create mode 100644 images/calendar.png diff --git a/boot.php b/boot.php index 0eccb8498..1c7a15705 100644 --- a/boot.php +++ b/boot.php @@ -4,9 +4,9 @@ set_time_limit(0); ini_set('pcre.backtrack_limit', 250000); -define ( 'FRIENDIKA_VERSION', '2.2.1004' ); +define ( 'FRIENDIKA_VERSION', '2.2.1005' ); define ( 'DFRN_PROTOCOL_VERSION', '2.21' ); -define ( 'DB_UPDATE_VERSION', 1062 ); +define ( 'DB_UPDATE_VERSION', 1063 ); define ( 'EOL', "
\r\n" ); define ( 'ATOM_TIME', 'Y-m-d\TH:i:s\Z' ); @@ -527,20 +527,8 @@ function check_config(&$a) { $plugins = get_config('system','addon'); $plugins_arr = array(); - if($plugins) { + if($plugins) $plugins_arr = explode(',',str_replace(' ', '',$plugins)); - if(get_config('system','strict_privacy')) { - unset($a->config['system']['huburl']); - for($x = 0; $x < count($plugins_arr); $x ++) { - if( $plugins_arr[$x] === 'facebook' - || $plugins_arr[$x] === 'twitter' - || $plugins_arr[$x] === 'statusnet') { - unset($plugins_arr[$x]); - } - } - } - } - $a->plugins = $plugins_arr; diff --git a/database.sql b/database.sql index fd7ccf87f..fa18c50dc 100644 --- a/database.sql +++ b/database.sql @@ -389,6 +389,7 @@ CREATE TABLE IF NOT EXISTS `user` ( `blockwall` tinyint(1) unsigned NOT NULL DEFAULT '0', `notify-flags` int(11) unsigned NOT NULL DEFAULT '65535', `page-flags` int(11) unsigned NOT NULL DEFAULT '0', + `prvnets` tinyint(1) NOT NULL DEFAULT '0', `pwdreset` char(255) NOT NULL, `maxreq` int(11) NOT NULL DEFAULT '10', `expire` int(11) unsigned NOT NULL DEFAULT '0', diff --git a/images/calendar.png b/images/calendar.png new file mode 100644 index 0000000000000000000000000000000000000000..fbf52933de7f7cf9303e03e4d94f222a4400bca0 GIT binary patch literal 853 zcmV-b1FHOqP)z@;j(q!3lK=n!AY({UO#lFTB>(_`g8%^e{{R4h=>PzA zFaQARU;qF*m;eA5Z<1fdMgRZ;%Sl8*RCwB?kD2LF4Q*k+~UfHzB0Y2sTFOtMZdc;r++q_F4wK@ zFTSL~<`8epPcuF~PN`Jl(~my@Kost{J{!lmyk#Bofk)#Ahp&r|;JJYg8%oWpyM zs4_b<#jQqWArKJ`?AyWqJ@=ssrP3HKr$JUqS>99Xd=tpU+wlFvcJvsA{Iw;QzH?49xyqjt!C{gl zVdRM;)c#l@-L)%q<0V+d50-Tl1`3=R;-F>k){I%iIoI68Wqv*Yiw zwDcQKKK>Zqd%X7)M~3L!dKWt%Jb(!dk#!#Dm9bN&dFq)H+;ev?)+^Vm3p83n|L%t< zfAl%`_TP^e<(GvjU3Ye~mIx|JB%&O7?ltoH4mxu=0GyXBH0KG!fR0>_j$8yl(oSh5 fDM`DHsPfMM54g5G4Iu5%00000NkvXXu0mjf+&Y7_ literal 0 HcmV?d00001 diff --git a/include/event.php b/include/event.php index 33970efff..9d9717a78 100644 --- a/include/event.php +++ b/include/event.php @@ -1,47 +1,121 @@ '; - $o .= '

' . bbcode($ev['desc']) . '

'; + $o .= '

' . bbcode($ev['desc']) . '

'; - $o .= '

' . t('Starts:') . ' ' . t('Starts:') . ' ' - . (($ev['adjust']) ? datetime_convert('UTC', date_default_timezone_get(), - $ev['start'] /*, format */ ) - : datetime_convert('UTC', 'UTC', - $ev['start'] /*, format */ )) + . (($ev['adjust']) ? day_translate(datetime_convert('UTC', date_default_timezone_get(), + $ev['start'] , $bd_format )) + : day_translate(datetime_convert('UTC', 'UTC', + $ev['start'] , $bd_format))) . '

'; if(! $ev['nofinish']) - $o .= '

' . t('Finishes:') . ' ' . t('Finishes:') . ' ' - . (($ev['adjust']) ? datetime_convert('UTC', date_default_timezone_get(), - $ev['finish'] /*, format */ ) - : datetime_convert('UTC', 'UTC', - $ev['finish'] /*, format */ )) + . (($ev['adjust']) ? day_translate(datetime_convert('UTC', date_default_timezone_get(), + $ev['finish'] , $bd_format )) + : day_translate(datetime_convert('UTC', 'UTC', + $ev['finish'] , $bd_format ))) . '

'; if(strlen($ev['location'])) - $o .= '

' . t('Location:') . '' + $o .= '

' . t('Location:') . '' . bbcode($ev['location']) . '

'; $o .= ''; - return $o; } +function parse_event($h) { + + require_once('include/Scrape.php'); + require_once('library/HTMLPurifier.auto.php'); + require_once('include/html2bbcode'); + + $h = '' . $h . ''; + + $ret = array(); + + $dom = HTML5_Parser::parse($h); + + if(! $dom) + return $ret; + + $items = $dom->getElementsByTagName('*'); + + foreach($items as $item) { + if(attribute_contains($item->getAttribute('class'), 'vevent')) { + $level2 = $item->getElementsByTagName('*'); + foreach($level2 as $x) { + if(attribute_contains($x->getAttribute('class'),'dtstart') && $x->getAttribute('title')) { + $ret['start'] = $x->getAttribute('title'); + if(! strpos($ret['start'],'Z')) + $ret['adjust'] = true; + } + if(attribute_contains($x->getAttribute('class'),'dtend') && $x->getAttribute('title')) + $ret['finish'] = $x->getAttribute('title'); + + if(attribute_contains($x->getAttribute('class'),'description')) + $ret['desc'] = $x->textContent; + if(attribute_contains($x->getAttribute('class'),'location')) + $ret['location'] = $x->textContent; + } + } + } + + // sanitise + + if((x($ret,'desc')) && ((strpos($ret['desc'],'<') !== false) || (strpos($ret['desc'],'>') !== false))) { + $config = HTMLPurifier_Config::createDefault(); + $config->set('Cache.DefinitionImpl', null); + $purifier = new HTMLPurifier($config); + $ret['desc'] = html2bbcode($purifier->purify($ret['desc'])); + } + + if((x($ret,'location')) && ((strpos($ret['location'],'<') !== false) || (strpos($ret['location'],'>') !== false))) { + $config = HTMLPurifier_Config::createDefault(); + $config->set('Cache.DefinitionImpl', null); + $purifier = new HTMLPurifier($config); + $ret['location'] = html2bbcode($purifier->purify($ret['location'])); + } + + if(x($ret,'start')) + $ret['start'] = datetime_convert('UTC','UTC',$ret['start']); + if(x($ret,'finish')) + $ret['finish'] = datetime_convert('UTC','UTC',$ret['finish']); + + return $ret; +} + + + + + + + + + + + + + function sort_by_date($a) { diff --git a/include/notifier.php b/include/notifier.php index 98e38fb11..cb4dfe025 100644 --- a/include/notifier.php +++ b/include/notifier.php @@ -27,8 +27,6 @@ function notifier_run($argv, $argc){ $a->set_baseurl(get_config('system','url')); - $prv = get_config('system','strict_privacy'); - logger('notifier: invoked: ' . print_r($argv,true)); $cmd = $argv[1]; @@ -332,9 +330,6 @@ function notifier_run($argv, $argc){ break; case 'stat': - if($prv) - break; - if($followup && $contact['notify']) { logger('notifier: slapdelivery: ' . $contact['name']); $deliver_status = slapper($owner,$contact['notify'],$slap); @@ -465,7 +460,7 @@ function notifier_run($argv, $argc){ if($slap && count($url_recipients) && $followup && $notify_hub && (! $expire)) { foreach($url_recipients as $url) { - if($url && (! $prv)) { + if($url) { logger('notifier: urldelivery: ' . $url); $deliver_status = slapper($owner,$url,$slap); // TODO: redeliver/queue these items on failure, though there is no contact record diff --git a/mod/dfrn_request.php b/mod/dfrn_request.php index 338dc9cf1..c9811fa60 100644 --- a/mod/dfrn_request.php +++ b/mod/dfrn_request.php @@ -626,11 +626,9 @@ function dfrn_request_content(&$a) { else $tpl = get_markup_template('auto_request.tpl'); - $prv = get_config('system','strict_privacy'); - $o .= replace_macros($tpl,array( '$header' => t('Friend/Connection Request'), - '$desc' => t('Examples: jojo@demo.friendika.com, http://demo.friendika.com/profile/jojo') . (($prv) ? ', testuser@identi.ca' : ''), + '$desc' => t('Examples: jojo@demo.friendika.com, http://demo.friendika.com/profile/jojo, testuser@identi.ca'), '$pls_answer' => t('Please answer the following:'), '$does_know' => sprintf( t('Does %s know you?'),$a->profile['name']), '$yes' => t('Yes'), @@ -638,9 +636,9 @@ function dfrn_request_content(&$a) { '$add_note' => t('Add a personal note:'), '$page_desc' => t("Please enter your 'Identity Address' from one of the following supported social networks:"), '$friendika' => t('Friendika'), - '$statusnet' => (($prv) ? t('StatusNet/Federated Social Web') : ''), + '$statusnet' => t('StatusNet/Federated Social Web'), '$private_net' => t("Private \x28secure\x29 network"), - '$public_net' => (($prv) ? t("Public \x28insecure\x29 network") : ''), + '$public_net' => t("Public \x28insecure\x29 network"), '$your_address' => t('Your Identity Address:'), '$submit' => t('Submit Request'), '$cancel' => t('Cancel'), diff --git a/mod/follow.php b/mod/follow.php index 31cfcfb64..a354b3457 100644 --- a/mod/follow.php +++ b/mod/follow.php @@ -34,9 +34,6 @@ function follow_post(&$a) { // NOTREACHED } - elseif(get_config('system','strict_privacy')) { - unset($ret['notify']); - } // do we have enough information? diff --git a/mod/salmon.php b/mod/salmon.php index bf33033d8..c2f76aa0a 100644 --- a/mod/salmon.php +++ b/mod/salmon.php @@ -192,11 +192,6 @@ function salmon_post(&$a) { // NOTREACHED } - // Check if we're allowed to talk to insecure networks - - if(get_config('system','strict_privacy')) - salmon_return(400); - require_once('include/items.php'); // Placeholder for hub discovery. We shouldn't find any hubs diff --git a/update.php b/update.php index dfc5f88c9..e1bc73619 100644 --- a/update.php +++ b/update.php @@ -1,6 +1,6 @@ Date: Wed, 8 Jun 2011 21:43:32 -0700 Subject: [PATCH 2/5] minor fixes to apps (don't show notes if not logged in) and photos (tag delete link is leaking to unauthorised users) --- mod/apps.php | 14 ++++++++++++-- mod/photos.php | 3 ++- 2 files changed, 14 insertions(+), 3 deletions(-) diff --git a/mod/apps.php b/mod/apps.php index 58752de32..f25722df7 100644 --- a/mod/apps.php +++ b/mod/apps.php @@ -5,10 +5,20 @@ function apps_content(&$a) { $o .= '

' . t('Applications') . '

'; - $o .= ''; + $apps = false; - if($a->apps) + if(local_user()) { + $apps = true; + $o .= ''; + } + + if($a->apps) { + $apps = true; $o .= $a->apps; + } + + if(! $apps) + notice( t('No installed applications.') . EOL); return $o; diff --git a/mod/photos.php b/mod/photos.php index f1a2d635c..f8749f5f7 100644 --- a/mod/photos.php +++ b/mod/photos.php @@ -1106,9 +1106,10 @@ function photos_content(&$a) { $tag_str .= bbcode($t); } $tags = array(t('Tags: '), $tag_str); - if($cmd === 'edit') + if($cmd === 'edit') { $tags[] = $a->get_baseurl() . '/tagrm/' . $link_item['id']; $tags[] = t('[Remove any tag]'); + } } From 894dfde122639cbcb90e4a07143fbe2f1d5c124a Mon Sep 17 00:00:00 2001 From: Friendika Date: Wed, 8 Jun 2011 22:34:22 -0700 Subject: [PATCH 3/5] set permalink on photo tags --- mod/photos.php | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/mod/photos.php b/mod/photos.php index f8749f5f7..18fff703e 100644 --- a/mod/photos.php +++ b/mod/photos.php @@ -510,8 +510,15 @@ foreach($_FILES AS $key => $val) { $arr['target'] .= '' . xmlify('' . "\n" . '') . ''; $item_id = item_store($arr); - if($item_id) + if($item_id) { + q("UPDATE `item` SET `plink` = '%s' WHERE `uid` = %d AND `id` = %d LIMIT 1", + dbesc($a->get_baseurl() . '/display/' . $owner_record['nickname'] . '/' . $item_id), + intval($page_owner_uid), + intval($item_id) + ); + proc_run('php',"include/notifier.php","tag","$item_id"); + } } } From d371241e66c4a68ef45415ac7c4ffe5283b3bff0 Mon Sep 17 00:00:00 2001 From: Friendika Date: Thu, 9 Jun 2011 00:58:45 -0700 Subject: [PATCH 4/5] events --- include/event.php | 2 +- mod/events.php | 2 +- view/theme/duepuntozero/style.css | 4 ++++ 3 files changed, 6 insertions(+), 2 deletions(-) diff --git a/include/event.php b/include/event.php index 9d9717a78..6962a2f1b 100644 --- a/include/event.php +++ b/include/event.php @@ -34,7 +34,7 @@ function format_event_html($ev,$pre = '') { . '

'; if(strlen($ev['location'])) - $o .= '

' . t('Location:') . '' + $o .= '

' . t('Location:') . ' ' . bbcode($ev['location']) . '

'; diff --git a/mod/events.php b/mod/events.php index f19a438fd..b480b7f6b 100644 --- a/mod/events.php +++ b/mod/events.php @@ -169,7 +169,7 @@ function events_content(&$a) { $prevyear --; } - + $o .= ''; $o .= '' . t('<< Previous') . ' | ' . t('Next >>') . ''; $o .= cal($y,$m,false, ' eventcal'); diff --git a/view/theme/duepuntozero/style.css b/view/theme/duepuntozero/style.css index 61a897904..68edd02b9 100644 --- a/view/theme/duepuntozero/style.css +++ b/view/theme/duepuntozero/style.css @@ -2227,6 +2227,10 @@ a.mail-list-link { font-size: 24px; } +#new-event-link { + margin-bottom: 10px; +} + .event-description:before { content: url('../../../images/calendar.png'); margin-right: 15px; From 9203b48527050b0b4a17120a95b2b3202842d56d Mon Sep 17 00:00:00 2001 From: Friendika Date: Thu, 9 Jun 2011 01:01:29 -0700 Subject: [PATCH 5/5] default event publish permissions = personal --- mod/events.php | 3 +++ 1 file changed, 3 insertions(+) diff --git a/mod/events.php b/mod/events.php index b480b7f6b..af829c28d 100644 --- a/mod/events.php +++ b/mod/events.php @@ -54,6 +54,9 @@ function events_post(&$a) { $str_contact_deny = perms2str($_POST['contact_deny']); + // until publishing is ready + $str_contact_allow = '<' . local_user() . '>'; + if($event_id) { $r = q("UPDATE `event` SET `edited` = '%s',