From 666cff7d553c9bab4fd156e403e244e0106b7bf4 Mon Sep 17 00:00:00 2001 From: Michael Date: Sat, 2 Oct 2021 11:08:12 +0000 Subject: [PATCH] "q" call is replaced --- src/Security/Security.php | 25 +++++++++++-------------- 1 file changed, 11 insertions(+), 14 deletions(-) diff --git a/src/Security/Security.php b/src/Security/Security.php index c4f8f4a5b..c6c2d806e 100644 --- a/src/Security/Security.php +++ b/src/Security/Security.php @@ -49,7 +49,7 @@ class Security return true; } - if (!empty(Session::getRemoteContactID($owner))) { + if (!empty($cid = Session::getRemoteContactID($owner))) { // use remembered decision and avoid a DB lookup for each and every display item // DO NOT use this function if there are going to be multiple owners // We have a contact-id for an authenticated remote user, this block determines if the contact @@ -60,22 +60,19 @@ class Security } elseif ($verified === 1) { return false; } else { - $cid = Session::getRemoteContactID($owner); - if (!$cid) { + $user = User::getById($owner); + if (!$user || $user['blockwall']) { + $verified = 1; return false; } - $r = q("SELECT `contact`.*, `user`.`page-flags` FROM `contact` INNER JOIN `user` on `user`.`uid` = `contact`.`uid` - WHERE `contact`.`uid` = %d AND `contact`.`id` = %d AND `contact`.`blocked` = 0 AND `contact`.`pending` = 0 - AND `user`.`blockwall` = 0 AND `readonly` = 0 AND (`contact`.`rel` IN (%d , %d) OR `user`.`page-flags` = %d) LIMIT 1", - intval($owner), - intval($cid), - intval(Contact::SHARING), - intval(Contact::FRIEND), - intval(User::PAGE_FLAGS_COMMUNITY) - ); - - if (DBA::isResult($r)) { + $contact = Contact::getById($cid); + if ($contact || $contact['blocked'] || $contact['readonly'] || $contact['pending']) { + $verified = 1; + return false; + } + + if (in_array($contact['rel'], [Contact::SHARING, Contact::FRIEND]) || ($user['page-flags'] == User::PAGE_FLAGS_COMMUNITY)) { $verified = 2; return true; } else {