From fb12807a339510845e5a8a1b0a7feeb0f534053b Mon Sep 17 00:00:00 2001
From: Cameron Fischer <fischer.cameron@gmail.com>
Date: Mon, 9 Sep 2019 09:56:40 -0400
Subject: [PATCH] Reverting changes to stringifyList (#4249)

I (Flibbles) changed it so that lists generated by stringifyList
would always be compatible with a filter parser, but since lists
are not, and never will be, a subset of filters, there isn't a
point.

More importantly, wrapping negative numbers like "-7" in brackets
would mess up some math stuff.
---
 boot/boot.js                               |  2 +-
 editions/test/tiddlers/tests/test-utils.js | 11 ++++++++++-
 2 files changed, 11 insertions(+), 2 deletions(-)

diff --git a/boot/boot.js b/boot/boot.js
index de5cc259b..82583c594 100644
--- a/boot/boot.js
+++ b/boot/boot.js
@@ -317,7 +317,7 @@ $tw.utils.stringifyList = function(value) {
 		var result = new Array(value.length);
 		for(var t=0, l=value.length; t<l; t++) {
 			var entry = value[t] || "";
-			if(entry.indexOf(" ") !== -1 || "+-~=".indexOf(entry[0]) !== -1) {
+			if(entry.indexOf(" ") !== -1) {
 				result[t] = "[[" + entry + "]]";
 			} else {
 				result[t] = entry;
diff --git a/editions/test/tiddlers/tests/test-utils.js b/editions/test/tiddlers/tests/test-utils.js
index e7af600ed..860cc4d51 100644
--- a/editions/test/tiddlers/tests/test-utils.js
+++ b/editions/test/tiddlers/tests/test-utils.js
@@ -32,10 +32,19 @@ describe("Utility tests", function() {
 		expect(str(["Tiddler8  "])).toEqual("[[Tiddler8  ]]");
 		expect(str(["A+B", "A-B", "A=B"])).toEqual("A+B A-B A=B");
 		expect(str(["A B"])).toEqual("[[A B]]");
-		expect(str(["+T", "-T", "~T", "=T", "$T"])).toEqual("[[+T]] [[-T]] [[~T]] [[=T]] $T");
+		// Starting special characters aren't treated specially,
+		// even though this makes a list incompatible with a filter parser.
+		expect(str(["+T", "-T", "~T", "=T", "$T"])).toEqual("+T -T ~T =T $T");
 		expect(str(["A", "", "B"])).toEqual("A  B");
 	});
 
+	it("stringifyList shouldn't interfere with setting variables to negative numbers", function() {
+		var wiki = new $tw.Wiki();
+		wiki.addTiddler({title: "test", text: "<$set name=X filter='\"-7\"'>{{{ [<X>add[2]] }}}</$set>"});
+		// X shouldn't be wrapped in brackets. If it is, math filters will treat it as zero.
+		expect(wiki.renderTiddler("text/plain","test")).toBe("-5");
+	});
+
 	it("should handle formatting a date string", function() {
 		var fds = $tw.utils.formatDateString,
 			// nov is month: 10!