From d321508437e100da15d7ef9227eae71f03df6280 Mon Sep 17 00:00:00 2001 From: David Johnston Date: Tue, 1 Oct 2013 10:50:13 +0100 Subject: [PATCH 1/2] Remove incorrect slice parameter. Remove incorrect slice parameter, which made the ! (not) prefix fail to return any results. --- core/modules/filters/limit.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/core/modules/filters/limit.js b/core/modules/filters/limit.js index 8075ec695..f2ea5b862 100644 --- a/core/modules/filters/limit.js +++ b/core/modules/filters/limit.js @@ -28,7 +28,7 @@ exports.limit = function(source,operator,options) { // Slice the array if necessary var limit = Math.min(source.length,parseInt(operator.operand,10)); if(operator.prefix === "!") { - results = source.slice(source.length - limit,limit); + results = source.slice(source.length - limit); } else { results = source.slice(0,limit); } From 154d5f316bc9e28de6945c3d719a5f057084d84c Mon Sep 17 00:00:00 2001 From: David Johnston Date: Tue, 1 Oct 2013 11:27:26 +0100 Subject: [PATCH 2/2] Added test for !limit (not limit) Added test for !limit (not limit) to ensure bug change works --- editions/test/tiddlers/tests/test-filters.js | 1 + 1 file changed, 1 insertion(+) diff --git a/editions/test/tiddlers/tests/test-filters.js b/editions/test/tiddlers/tests/test-filters.js index 19d74f35e..926c12ed6 100644 --- a/editions/test/tiddlers/tests/test-filters.js +++ b/editions/test/tiddlers/tests/test-filters.js @@ -141,6 +141,7 @@ describe("Filter tests", function() { it("should handle the limit operator", function() { expect(wiki.filterTiddlers("[!is[system]sort[title]limit[2]]").join(",")).toBe("a fourth tiddler,one"); expect(wiki.filterTiddlers("[prefix[Tid]sort[title]limit[1]]").join(",")).toBe("Tiddler Three"); + expect(wiki.filterTiddlers("[prefix[Tid]sort[title]!limit[1]]").join(",")).toBe("TiddlerOne"); }); it("should handle the list operator", function() {