From d5d73e02e9080a4c6f779e94a4ab281cd8a2e7b6 Mon Sep 17 00:00:00 2001 From: "jeremy@jermolene.com" Date: Sat, 2 Oct 2021 16:17:07 +0100 Subject: [PATCH] Fix bug with innerwiki template The problem was that the innerwiki template included the tiddler $:/plugins/tiddlywiki/railroad, which was omitted from the wiki. Unexpectedly, missing tiddlers were rendered by the jsontiddler widget as an empty object {}. The fix is to always include the title when the tiddler is missing. Also cleaned up the template to remove unneeded tiddlers --- core/modules/widgets/jsontiddler.js | 2 ++ editions/innerwikidemo/tiddlywiki.info | 3 ++- plugins/tiddlywiki/innerwiki/template.tid | 4 ---- 3 files changed, 4 insertions(+), 5 deletions(-) diff --git a/core/modules/widgets/jsontiddler.js b/core/modules/widgets/jsontiddler.js index d40432e9f..44a9e50e3 100644 --- a/core/modules/widgets/jsontiddler.js +++ b/core/modules/widgets/jsontiddler.js @@ -79,6 +79,8 @@ JSONTiddlerWidget.prototype.getTiddlerFields = function() { var tiddler = this.wiki.getTiddler(this.attTiddler); if(tiddler) { fields = tiddler.getFieldStrings({exclude: this.attExclude.split(" ")}); + } else { + fields = {title: this.attTiddler}; } } return fields; diff --git a/editions/innerwikidemo/tiddlywiki.info b/editions/innerwikidemo/tiddlywiki.info index 45b47a0bc..2a55c68d0 100644 --- a/editions/innerwikidemo/tiddlywiki.info +++ b/editions/innerwikidemo/tiddlywiki.info @@ -1,7 +1,8 @@ { "description": "Innerwiki Plugin Demo", "plugins": [ - "tiddlywiki/innerwiki" + "tiddlywiki/innerwiki", + "tiddlywiki/railroad" ], "themes": [ "tiddlywiki/vanilla", diff --git a/plugins/tiddlywiki/innerwiki/template.tid b/plugins/tiddlywiki/innerwiki/template.tid index 4c4a36c70..57ce4b543 100644 --- a/plugins/tiddlywiki/innerwiki/template.tid +++ b/plugins/tiddlywiki/innerwiki/template.tid @@ -1,11 +1,7 @@ title: $:/plugins/tiddlywiki/innerwiki/template \define saveTiddlerFilter() -$:/boot/boot.css -$:/boot/boot.js -$:/boot/bootprefix.js $:/core -$:/library/sjcl.js $:/plugins/tiddlywiki/innerwiki $:/plugins/tiddlywiki/railroad $:/themes/tiddlywiki/snowwhite