From 459133cc57967002e9f0c4f52fc2f5f78cbbf6ba Mon Sep 17 00:00:00 2001
From: Jermolene <jeremy@osmosoft.com>
Date: Sun, 28 Sep 2014 23:46:55 +0100
Subject: [PATCH] Remove unused file watching code from filesystemadaptor
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

This code was contributed by @natecain and added in #176. It was almost
immediately disabled because of problems in the field.

I’m removing the code now to simplify the adaptor in advance of some
planned refactoring.
---
 .../filesystem/filesystemadaptor.js           | 49 ++-----------------
 1 file changed, 5 insertions(+), 44 deletions(-)

diff --git a/plugins/tiddlywiki/filesystem/filesystemadaptor.js b/plugins/tiddlywiki/filesystem/filesystemadaptor.js
index 18cb4cba2..93c7dd785 100644
--- a/plugins/tiddlywiki/filesystem/filesystemadaptor.js
+++ b/plugins/tiddlywiki/filesystem/filesystemadaptor.js
@@ -19,33 +19,9 @@ var fs = !$tw.browser ? require("fs") : null,
 function FileSystemAdaptor(options) {
 	var self = this;
 	this.wiki = options.wiki;
-	this.watchers = {};
-	this.pending = {};
 	this.logger = new $tw.utils.Logger("FileSystem");
-	this.setwatcher = function(filename, title) {
-		return undefined;
-		//return this.watchers[filename] = this.watchers[filename] ||
-		//	fs.watch(filename, {persistent: false}, function(e) {
-		//		self.logger.log("Error:",e,filename);
-		//		if(e === "change") {
-		//			var tiddlers = $tw.loadTiddlersFromFile(filename).tiddlers;
-		//			for(var t in tiddlers) {
-		//				if(tiddlers[t].title) {
-		//					self.wiki.addTiddler(tiddlers[t]);
-		//				}
-		//			}
-		//		}
-		//	});
-	};
-	for(var f in $tw.boot.files) {
-		var fileInfo = $tw.boot.files[f];
-		this.setwatcher(fileInfo.filepath, f);
-	}
 	// Create the <wiki>/tiddlers folder if it doesn't exist
-	// TODO: we should create the path recursively
-	if(!fs.existsSync($tw.boot.wikiTiddlersPath)) {
-		fs.mkdirSync($tw.boot.wikiTiddlersPath);
-	}
+	$tw.utils.createDirectory($tw.boot.wikiTiddlersPath);
 }
 
 FileSystemAdaptor.prototype.getTiddlerInfo = function(tiddler) {
@@ -92,7 +68,6 @@ FileSystemAdaptor.prototype.getTiddlerFileInfo = function(tiddler,callback) {
 			fileInfo.hasMetaFile = typeInfo.hasMetaFile;
 			// Save the newly created fileInfo
 			$tw.boot.files[title] = fileInfo;
-			self.pending[fileInfo.filepath] = title;
 			// Pass it to the callback
 			callback(null,fileInfo);
 		});
@@ -128,22 +103,13 @@ Save a tiddler and invoke the callback with (err,adaptorInfo,revision)
 FileSystemAdaptor.prototype.saveTiddler = function(tiddler,callback) {
 	var self = this;
 	this.getTiddlerFileInfo(tiddler,function(err,fileInfo) {
-		var template, content, encoding;
-		function _finish() {
-			if(self.pending[fileInfo.filepath]) {
-				self.setwatcher(fileInfo.filepath, tiddler.fields.title);
-				delete self.pending[fileInfo.filepath];
-			}
-			callback(null, {}, 0);
-		}
+		var template, content, encoding,
+			_finish = function() {
+				callback(null, {}, 0);
+			};
 		if(err) {
 			return callback(err);
 		}
-		if(self.watchers[fileInfo.filepath]) {
-			self.watchers[fileInfo.filepath].close();
-			delete self.watchers[fileInfo.filepath];
-			self.pending[fileInfo.filepath] = tiddler.fields.title;
-		}
 		if(fileInfo.hasMetaFile) {
 			// Save the tiddler as a separate body and meta file
 			var typeInfo = $tw.config.contentTypeInfo[fileInfo.type];
@@ -192,11 +158,6 @@ FileSystemAdaptor.prototype.deleteTiddler = function(title,callback,options) {
 		fileInfo = $tw.boot.files[title];
 	// Only delete the tiddler if we have writable information for the file
 	if(fileInfo) {
-		if(this.watchers[fileInfo.filepath]) {
-			this.watchers[fileInfo.filepath].close();
-			delete this.watchers[fileInfo.filepath];
-		}
-		delete this.pending[fileInfo.filepath];
 		// Delete the file
 		fs.unlink(fileInfo.filepath,function(err) {
 			if(err) {