From 12661f5cdaca19135801ca9b47449e0eeadfb0c4 Mon Sep 17 00:00:00 2001 From: Jermolene Date: Thu, 31 Mar 2016 11:14:15 +0100 Subject: [PATCH] Add warning for bad characters when editing tiddler titles Fixes #2351 --- core/language/en-GB/EditTemplate.multids | 1 + core/ui/EditTemplate/title.tid | 16 +++++++++++++++- 2 files changed, 16 insertions(+), 1 deletion(-) diff --git a/core/language/en-GB/EditTemplate.multids b/core/language/en-GB/EditTemplate.multids index f56deeead..bf19b3e45 100644 --- a/core/language/en-GB/EditTemplate.multids +++ b/core/language/en-GB/EditTemplate.multids @@ -21,6 +21,7 @@ Tags/Add/Button: add Tags/Add/Placeholder: tag name Tags/Dropdown/Caption: tag list Tags/Dropdown/Hint: Show tag list +Title/BadCharacterWarning: Warning: avoid using any of the characters <> in tiddler titles Type/Dropdown/Caption: content type list Type/Dropdown/Hint: Show content type list Type/Delete/Caption: delete content type diff --git a/core/ui/EditTemplate/title.tid b/core/ui/EditTemplate/title.tid index 829f91afe..a6d41895b 100644 --- a/core/ui/EditTemplate/title.tid +++ b/core/ui/EditTemplate/title.tid @@ -1,4 +1,18 @@ title: $:/core/ui/EditTemplate/title tags: $:/tags/EditTemplate -<$edit-text field="draft.title" class="tc-titlebar tc-edit-texteditor" focus="true"/> \ No newline at end of file +<$vars pattern="""[\|\[\]{}"]""" bad-chars="""`| [ ] { } " '`"""> + +<$list filter="[is[current]regexp:draft.title]" variable="listItem"> + +
+ +{{$:/language/EditTemplate/Title/BadCharacterWarning}} + +
+ + + + + +<$edit-text field="draft.title" class="tc-titlebar tc-edit-texteditor" focus="true"/>